Update designs of flash messages sitewide

What does this MR do?

Issue #22992 (closed)

• Update designs of flash messages sitewide to follow this spec for all 4 flash types: alert, notice, success, warning. This fixes the issue with the link contrast.

Relevant links:

• gitlab-ui!832 (merged)
• https://design.gitlab.com/components/alert

Screenshots

Before

After

Before

After

Before

After

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team