Ignore incoming emails with X-Autoreply
What does this MR do?
Ignore incoming emails with X-Autoreply
Some messages may not contains the RFC-compliant Auto-Submitted header, instead they may use X-Autoreply header for automated replies (e.g. out of office emails).
Note that this fix may not be definitive, some blogs and other "unofficial" sources mention also other headers to check, but we can add other iteratively if needed. Redmine uses same set (https://www.redmine.org/projects/redmine/repository/entry/branches/4.0-stable/app/models/mail_handler.rb#L82) so let's use the same for now.
Related to #30327 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.4
added backend devopsplan typebug + 1 deleted label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Tiger Watson ( @tigerwnz
)Dmitriy 'DZ' Zaporozhets ( @dzaporozhets
)Generated by
Dangermarked the checklist item Changelog entry as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
@digitalmoksha could you please review?
assigned to @digitalmoksha
@jprovaznik I love it when everybody does something different
: https://github.com/jpmckinney/multi_mail/wiki/Detecting-autorespondersAgree that we can iterate on this as the need arises.
LGTM!
unassigned @digitalmoksha
@dzaporozhets would you be able to do the maintainer review?
assigned to @dzaporozhets
@digitalmoksha thanks, LGTM!
mentioned in commit 986b5abb
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.4.201910130810-44adee04c32.30ae0ff6d6f
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.4.201910130810-44adee04c32.30ae0ff6d6f
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.4.201910160011-08e6905db3d.4748e740ecf
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
added bugperformance label
added groupproduct planning label and removed 1 deleted label
mentioned in issue #432208