Skip to content

Add instance security dashboard permissions

Avielle Wolfe requested to merge instance-security-dashboard-permissions into master

What does this MR do?

This MR adds a permissions scheme for the upcoming instance security dashboard, along with the controllers that will use that permissions scheme. The actions in the controllers are placeholders that will be implement at a later point.

The permission scheme for the dashboard is very generous because by default every user's instance level security dashboard will be blank. They will be able to populate it with projects they have access to, so permission restrictions will apply when they are adding a project to the dashboard.

Acceptance Criteria

As any user on an Ultimate instance of Gitlab
When I go to the instance security dashboard
Then I see that I have access to the page.

As any user on an instance of Gitlab with any license less than Ultimate
When I go to the instance security dashboard
Then I see that the page is not found.

#6953 (closed) #33831 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Avielle Wolfe

Merge request reports