Skip to content

Add validation for expires_at in expirable concern

Horatiu Eugen Vlad requested to merge hvlad/gitlab:fix/validate_expire_at into master

What does this MR do?

Introduce the date validation for expires_at field of the Expirable concern for both invalid and in the past date values.

The date validator is added as part of the Gitlab code base to avoid introduction of one more external dependency.

Fixes #28678 (closed)

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

label security

Edited by Imre Farkas

Merge request reports