Reduce redundancy and move source/target branch selectors to top of MR view
What does this MR do?
[Relates to #29857 (closed)]
This MR moves the source and target branch selector dropdowns to be just below the "New Merge Request" header.
In most cases, the dropdowns don't show, and only a <code> block with the project paths is shown.
In the case of Editing an existing MR, the target branch is replaced with a branch selector dropdown.
By moving them there, a bit of redundancy of the top metadata (i.e. "From branch-x to branch-y") was exposed. That section of the UI is completely removed.
One item is sized using a design spec for forms. Under the assumption that these widths could be consistent and likely used more in the future, I've added them and a utility class.
Screenshots
| Before | After | |
|---|---|---|
| New |  |
 |
| Edit |  |
 |
| New (From Fork) |  |
 |
| Edit (From Fork) |  |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
~~Label as security and @ mention @gitlab-com/gl-security/appsec~~ -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team