Skip to content

Ide render whitespaces

Mathieu Parent requested to merge sathieu/gitlab:ide_render_whitespaces into master

What does this MR do?

Render whitespaces in Web IDE

Replaces gitlab-foss!24862 (closed).

Screenshots

Description Screenshot (90a28dc4 on 2019-11-12)
User preferences Screen_Shot_2019-11-12_at_9.46.01_AM
When enabled, IDE shows whitespace as faded dot Screen_Shot_2019-11-12_at_9.47.03_AM
When disabled, IDE is the same Screen_Shot_2019-11-12_at_9.48.44_AM

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Remaining

  • Add screenshots to this MR (of the user preferences and editor).
  • UX review
  • 🔨 Add FE unit tests
  • 🔨 Add BE unit tests
  • 🔨 Add feature spec for new user preference field
  • 🔨 Add feature spec for IDE when render whitespace is enabled / disabled (there might be issues with this)... It looks like there are issues with feature specs in the IDE, so we can just assert that the data attribute gets set correctly.
  • FE review
  • BE review
  • Merge 🚀
Edited by Nick Thomas

Merge request reports