Skip to content

Add scope filter to security dashboards

Paula Burke requested to merge 9102-hide-dismissed-be into master

What does this MR do?

Related Issue: #9102 (closed)

Uses scope param to filter dismissed vulnerabilities on the group and project security dashboards. This uses the same params, values, and behavior as the Vulnerabilities API.

Default behavior: exclude dismissed vulnerabilities

params[:scope] = all: return all associated vulnerabilities

params[:scope] = dismissed: exclude dismissed vulnerabilities

Note: It is confusing that the scope value dismissed excludes dismissed vulnerabilities instead of returning only dismissed vulnerabilities. We want the behavior to be the same as the Vulnerabilities API. The naming of the scopes should be updated for clarity, but changing the behavior of the existing API is beyond the scope of this MR.

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports