Skip to content
Snippets Groups Projects

Add finder for prometheus metrics

Merged Sarah Yasonik requested to merge add-metrics-finder-ee into master

What does this MR do?

Adds a finder for the standard PrometheusMetrics model. This was a follow-up item from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31063#note_200076126.

Updates references to prometheus metrics to use the finder. Note that the PrometheusMetric model used for importing common metrics into the db is different and not related to this work.

Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65753

Previous FOSS MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31854

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sarah Yasonik resolved all threads

    resolved all threads

  • 1 Warning
    :warning: This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Qingyu Zhao (@qzhaogitlab) Jan Provaznik (@jprovaznik)

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Sarah Yasonik changed milestone to %12.3

    changed milestone to %12.3

  • Sarah Yasonik marked as a Work In Progress

    marked as a Work In Progress

  • Sarah Yasonik changed title from EE port: Add finder for prometheus metrics to WIP: Add finder for prometheus metrics

    changed title from EE port: Add finder for prometheus metrics to WIP: Add finder for prometheus metrics

  • Sarah Yasonik changed the description

    changed the description

  • mentioned in issue #32526 (closed)

  • mentioned in issue #32730 (closed)

  • 🤖 GitLab Bot 🤖 changed milestone to %12.4

    changed milestone to %12.4

  • mentioned in issue #34388 (closed)

  • Sarah Yasonik added 4350 commits

    added 4350 commits

    Compare with previous version

  • Sarah Yasonik added 311 commits

    added 311 commits

    Compare with previous version

  • Sarah Yasonik added 2 commits

    added 2 commits

    Compare with previous version

  • Sarah Yasonik unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Author Developer

    @.luke Would you be willing to review this MR? (Overriding danger's suggestion because this is pretty similar to app/finders/award_emojis_finder.rb)

  • Sarah Yasonik assigned to @.luke and unassigned @syasonik

    assigned to @.luke and unassigned @syasonik

  • Luke Duncalfe changed milestone to %12.5

    changed milestone to %12.5

  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • assigned to @syasonik

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading