Add finder for prometheus metrics
What does this MR do?
Adds a finder for the standard PrometheusMetrics
model. This was a follow-up item from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31063#note_200076126.
Updates references to prometheus metrics to use the finder. Note that the PrometheusMetric
model used for importing common metrics into the db is different and not related to this work.
Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/65753
Previous FOSS MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31854
Does this MR meet the acceptance criteria?
Conformity
- [n/a] Changelog entry
- [n/a] Documentation created/updated or follow-up review issue created
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [n/a] Database guides
-
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.4
added backend backstage [DEPRECATED] devopsmonitor grouprespond + 1 deleted label
added 2 commits
- Resolved by Sarah Yasonik
1 Warning This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Qingyu Zhao ( @qzhaogitlab
)Jan Provaznik ( @jprovaznik
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %12.3
mentioned in issue #32526 (closed)
added missed:12.3 label
mentioned in issue #32730 (closed)
changed milestone to %12.4
mentioned in issue #34388 (closed)
added missed:12.4 label
added 4350 commits
-
b5c56453...7754808a - 4347 commits from branch
master
- 0f7e805d - Add finder for prometheus metrics
- 0fe6efd2 - Switch EE usages to finder
- 0c41c1fd - Add unindexed query protection
Toggle commit list-
b5c56453...7754808a - 4347 commits from branch
added 311 commits
-
0c41c1fd...c392490a - 308 commits from branch
master
- 45a6c7cd - Add finder for prometheus metrics
- 7dd667a1 - Switch EE usages to finder
- c4cdeba1 - Add unindexed query protection
Toggle commit list-
0c41c1fd...c392490a - 308 commits from branch
added 2 commits
@.luke Would you be willing to review this MR? (Overriding danger's suggestion because this is pretty similar to
app/finders/award_emojis_finder.rb
)changed milestone to %12.5
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
- Resolved by Luke Duncalfe
- Resolved by Luke Duncalfe
- Resolved by Sarah Yasonik
- Resolved by Sarah Yasonik
assigned to @syasonik