Skip to content

Sort wiki pages by date

Alex Kalderimis requested to merge ee-sort-wiki-pages-by-date into master

What does this MR do?

This MR changes the way the pages listings are presented to the user in the wikis. It adds two new modes, currently selectable by the end-user, in addition to the current default:

  • nested, grouped by folder/directory (current default)
  • flattened, just leaf nodes
  • trimmed, just top-level nodes (folders or leaves)

To make this work as now, it is important to add the ability to descend into directories directly, which present their children as the pages view. Currently we only support a single level of nesting.

The new behaviour is:

  • when sorting by title, show the listing in trimmed mode. Selecting a directory lists the pages in that directory.
  • when sorting by date, show the listing in flat mode.

The nesting mode is currently fixed by sort order. A control to select it is available but hidden behind a feature flag.

This MR fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/60110 This MR replaces: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30245

The CE MR was previously approved by @.luke and @shampton, and is currently in maintainer review.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

This makes significant changes to the way information is presented. It is necessary to have the UX reviewed by a member of design and front-end to make sure that this makes sense.

This includes front-end work, but currently the wikis are purely presented with rails templates, minimising browser compatibility issues. Nonetheless, cross-browser testing is going to be required.

Edited by 🤖 GitLab Bot 🤖

Merge request reports