Skip to content

Allow SmartCard authentication to use SAN extensions

Sebastián Arcila Valenzuela requested to merge 8605-support-san-extension into master

What does this MR do?

This adds flexibility to the SmartCard authentication with X.509 certificates by using SubjectAlternateName (SAN) extensions to pickup the email address (rfc822Name) that match as an alternate name for the GitLab instance (URI), which removes the limitation of using the email as part of the Common-Name of the certificate.

Related links

Issue: https://gitlab.com/gitlab-org/gitlab-ee/issues/8605

CE backport: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32581

Omnibus MR: omnibus-gitlab!3566 (merged)

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #8605 (closed)

Edited by Thong Kuah

Merge request reports