Skip to content

Allow empty approval rule

Igor Drozdov requested to merge id-allow-empty-rule into master

Allows empty approval rule to be created which allows combining the behavior of fallback rule and regular rules.

That's useful in case we need a certain number of approvals from a particular group and a certain number of approvals from any developer

Scenarios

A. Project Settings Page

  • Ultimate License

Multiple Rules

image

Single Rule

image

  • Starter License

Only 1 ruled is shown (either named or any rule)

image

named rule

image

B. New Merge Request

  • Ultimate License
  • Can override approvers and approvals required per merge request 

image

  • Ultimate License
  • Can override approvers and approvals required per merge request 

You can not edit rules (set from project settings) OR add approval rules

image

  • Starter License
  • Can override approvers and approvals required per merge request 

Only 1 rule is displayed

image

  • Starter License
  • Can override approvers and approvals required per merge request 

Only 1 rule is displayed. You can not edit rules (that was set from project settings) OR add approval rules

image

C. Edit Merge Request

  • Ultimate License
  • Can override approvers and approvals required per merge request 

image

named rule

image

  • Ultimate License
  • Can override approvers and approvals required per merge request 

You can not edit rules (that was set from project settings) OR add approval rules

image

image

  • Starter License
  • Can override approvers and approvals required per merge request 

Only 1 rule is displayed

image

image

  • Starter License
  • Can override approvers and approvals required per merge request 

Only 1 rule is displayed. You can not edit rules (that was set from project settings) OR add approval rules

image

image

Related issue

https://gitlab.com/gitlab-org/gitlab-ee/issues/13215

Does this MR meet the acceptance criteria?

Conformity

Edited by Bob Van Landuyt

Merge request reports