Hide dismissed vulnerabilities in security dashboards
Previously part of https://gitlab.com/gitlab-org/gitlab-ee/issues/6240, but not finished in the %11.7 iteration.
We should follow up with this separate issue.
Description
When dealing with security dashboards, users should be able to hide dismissed vulnerabilities from the entire dashboard, so they can work on what's important and remove the noise created by these dismissed vulns.
Proposal
Add a hide/show toggle to the filters area that effectively hides all dismissed vulnerabilities.
Experience
Dashboard with filters - first state |
![multiple-report-types-active](data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==) |
Filter detail
Hide dismissed toggle |
![Screen_Shot_2018-12-11_at_1.37.35_PM](data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==) |
When the "Hide dismissed" toggle is on and the user dismisses a vulnerability, we should display a toast at the bottom left of the window, and reload the dashboard with the newly dismissed vulnerability hidden. See more below > |
Dismissing a vulnerability with the "Hide dismissed" toggle active |
![Screen_Shot_2018-12-11_at_2.56.34_PM](data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==) |
Once the user has clicked the dismiss vulnerability button, the dismissed vulnerability will hide and the list will shift up, adding 1 new vulnerability at the bottom of the list. The user will also see a toast appear with an ease-in animation from the bottom and display at the left-bottom of the screen alerting the user of their action. After a short while, the toast will ease-out with the opposite motion. |
If the user has the "Hide dismissed" toggle off, no motion will be applied to the vulnerability and no toast will appear. The dismissed vulnerability will appear as they do today, with the button for dismiss changing to the undo icon. |
Edge cases
TBD
Documentation
Update the (Security Dashboard)[https://docs.gitlab.com/ee/user/application_security/security_dashboard/] documentation to provide detail on what, specifically, the Hide Dismissed
toggle does. Also remove the reference to 12.5 availability when this feature is complete and no longer behind a feature flag.
Design Specs:
See design specs here