Merge request commit message is set in stone ahead-of-time when using "merge when pipeline succeeds"
Summary
If you have a running CI pipeline and say "merge when pipeline succeeds", and then (while the pipeline is still running) change the description, the commit message of the resulting merge contains the old MR description
Steps to reproduce
- Have a CI pipeline that takes a little bit of time
- Configure the project to do merge requests, and allow users to select "merge when pipeline succeeds"
- Configure the project to not need approvers etc. ... the only gating factor for merge-to-master should be a CI pipeline
- Push a branch
- Make a merge request with some description "DescriptionFooBar1"
- See that the pipeline is still running (if not, push an amended commit to the branch or make the CI pipeline slower)
- Click the button "merge when pipeline succeeds"
- See that the pipeline is still running
- Edit the description of the merge request to say something different like "GitlabRules2"
- Eventually, see the pipeline succeed and the commit to get merged into master
- See the commit message that ended up on master
What is the current bug behavior?
The commit message on master has the first/former description
What is the expected correct behavior?
The commit message should have the later description