ee-specific-lines-check didn't properly detect the difference
Here's the offending job: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/88311948
This is false negative.
The following discussion from !6672 (merged) should be addressed:
-
@godfat commented on a discussion: (+14 comments) I am surprised that it's green. I tried to re-run it and it's still green. This doesn't make sense because we still have a few difference. We're not ignoring YAML files in the script. Even if we did everything, it should still complain about those YAML files. I think the job must have some kinds of bugs.
Also,
app/assets/javascripts/environments/components/environment_item.vue
is back with some difference, which we explicitly created follow ups: https://gitlab.com/gitlab-org/gitlab-ee/issues/7195Together with those EE constants we need to deal with: https://gitlab.com/gitlab-org/gitlab-ee/issues/7204
I think we're ok here, but not because it's green it's because we have follow ups.
Resolving for now. This merge request is slowing my Firefox down which makes examining the difference pretty difficult unless I am doing this locally with command line Git.