Order-dependent spec failure on master: ee/spec/services/projects/update_mirror_service_spec.rb
E.g.: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/57388692
Failure:
Failures:
1) Projects::UpdateMirrorService#execute when the mirror user doesn't have access fails
Failure/Error: expect(result[:status]).to eq(:error)
expected: :error
got: :success
(compared using ==)
Diff:
@@ -1,2 +1,2 @@
-:error
+:success
# ./ee/spec/services/projects/update_mirror_service_spec.rb:197:in `block (4 levels) in <top (required)>'
Finished in 25 minutes 22 seconds (files took 35.03 seconds to load)
1876 examples, 1 failure, 1 pending
Failed examples:
rspec ./ee/spec/services/projects/update_mirror_service_spec.rb:192 # Projects::UpdateMirrorService#execute when the mirror user doesn't have access fails
Files run:
ee/spec/features/boards/scoped_issue_board_spec.rb
ee/spec/features/issuables/related_issues_spec.rb
ee/spec/models/burndown_spec.rb
ee/spec/features/boards/sidebar_spec.rb
ee/spec/models/project_spec.rb
ee/spec/elastic_integration/global_search_spec.rb
ee/spec/policies/group_policy_spec.rb
ee/spec/features/merge_request/user_sets_approvers_spec.rb
ee/spec/lib/gitlab/checks/change_access_spec.rb
ee/spec/features/boards/multiple_boards_spec.rb
ee/spec/features/issues/service_desk_spec.rb
ee/spec/features/merge_request/user_approves_spec.rb
ee/spec/features/es_group_search_spec.rb
ee/spec/features/projects/audit_events_spec.rb
ee/spec/uploaders/workers/object_storage/migrate_uploads_worker_spec.rb
ee/spec/models/merge_request_spec.rb
ee/spec/features/epics/update_epic_spec.rb
ee/spec/services/projects/update_remote_mirror_service_spec.rb
ee/spec/helpers/push_rules_helper_spec.rb
ee/spec/controllers/projects/mirrors_controller_spec.rb
ee/spec/services/projects/create_service_spec.rb
ee/spec/controllers/boards/issues_controller_spec.rb
ee/spec/features/issues/csv_spec.rb
ee/spec/controllers/groups/epic_issues_controller_spec.rb
ee/spec/features/es_global_search_spec.rb
ee/spec/models/push_rule_spec.rb
ee/spec/models/project_import_data_spec.rb
ee/spec/models/ee/relative_positioning_spec.rb
ee/spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb
ee/spec/migrations/update_authorized_keys_file_spec.rb
ee/spec/models/concerns/elastic/repository_spec.rb
ee/spec/features/ci_shared_runner_warnings_spec.rb
ee/spec/controllers/projects/boards_controller_spec.rb
ee/spec/services/projects/update_mirror_service_spec.rb
The spec seems to pass reliably by itself, but failed twice in a row on CI with this particular ordering. I'm running all these specs locally now to verify that it fails.