Closing issues in GitLab-JIRA integration
I was testing the GitLab-JIRA integration with GitLab 10.0.2-ee and JIRA 7.3.0, especially closing JIRA issues from GitLab.
First of all, I didn't find a definition of Closing
. Different workflows may have different names for end states. Moreover, there can be more than one end state (e.g., Reject
and Done
). A more unambiguous definition would be to say that, as a result of a commit or MR, the issue will do the transition whose ID is provided on the JIRA integration tab, provided:
- The transition's target state belongs to category
Done
. - The issue is in that transition's source state.
- The JIRA user has the right to perform that transition.
(BTW, I would prefer to remove condition 1. Not everyone wants an MR to really close the issue. There may be some additional steps, like QA approval, before an issue is closed).
But is it indeed so?
I did some tests using the following workflow: To Do -> In Progress -> In Review -> Done
, with state Done
belonging to category Done
:
Test 1.
- Set up the integration so that the transition moves from
In Progress
toIn Review
. - Move an issue manually to
In Progress
. - Create a commit with "Fixes ..." in the description.
*Result*:
The issue moved to `In Review`, but no link or comment were added to the issue.
Test 2.
- Change the integration setup so that now the transition moves from
In Review
toDone
. - Note that the issue is now
In Review
. - Create a commit with "Fixes ..." in the description.
*Result*:
The issue moved to `Done` and a link and a comment were added to the issue.
I think that both the documentation and the internal logic need some fixing.