Designs tab: Deleting a design doesn't actually delete
One big problem with how we set up versioning of the design "batch" is that when someone deletes a design, it doesn't actually delete it. You can go to a previous version to see the deleted design, which could be a problem for someone who might accidentally put up something confidential (or worse).
I've also gathered feedback around the confusing nature of the versioning of design batches. I understand this is what's happening under the hood, but I'm not sure how much value we're getting out of viewing older and newer versions of design batches. All we really get out of them is what's been added/modified/deleted, but you still need to look at the design itself to be able to see what was modified.
This is probably related to #37296 in how we use Git to handle design management.
Proposal
- Rename existing
deleted
state toarchived
. - Actually delete designs permanently (which is what someone expects when they delete something)
Permissions and Security
- If you can add/update a design, you should also be able to delete/archive a design.
Availability & Testing
- Unit tests of
DesignsFinder
. - Unit tests of GraphQL mutation (including errors, input validation, authorization).
- Migration test for the renamed state.
Merge request breakdown
Has been split into three four implementation issues:
See also:
- Rename
Delete
toArchive
(both in the UI and the mutation). - Add new
Delete
mutation and UI action.
See design in designs tab
Documentation
- Highlight that the previous "Delete" was renamed to "Archive".
Prototype
https://sketch.cloud/s/GxoOL/a/ZDL8E3/play. Sketch cloud now has an inspector!