Designs are not migrated during migration to Hashed Storage
Summary
Designs are not migrated during migration to Hashed Storage (they are missing in <hash>.design.git
). Designs uploaded after migration are working.
Steps to reproduce
- Use design management in a legacy project with GitLab 12.4.3
- Upgrade to GitLab 12.5.0 (=> design management will be disabled, because Hashed Storage is required)
- Call
sudo gitlab-rake gitlab:storage:migrate_to_hashed
What is the current bug behavior?
Old designs are broken after upgrade (see screenshot below)
<hash>.design.git
has only revision of containing design changes done after migration.
What is the expected correct behavior?
Old designs should be accessible after upgrading.
<hash>.design.git
has should contain design changes done before and after migration.
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 18.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 3.2.12 Git Version: 2.22.0 Sidekiq Version:5.2.7 Go Version: unknownGitLab information Version: 12.5.0-ee Revision: 4878f9ac894 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.9 URL: https://gitlab.hpi3d.de HTTP Clone URL: https://gitlab.hpi3d.de/some-group/some-project.git SSH Clone URL: git@gitlab.hpi3d.de:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 10.2.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 8/4 ... yes 6/7 ... yes 6/14 ... yes 6/15 ... yes 6/16 ... yes 6/17 ... yes 6/18 ... yes 6/29 ... yes 18/30 ... yes 18/31 ... yes 18/32 ... yes 30/40 ... yes 29/46 ... yes 9/48 ... yes 34/49 ... yes 6/51 ... yes 36/53 ... yes 8/54 ... yes 42/58 ... yes 6/59 ... yes 10/60 ... yes 9/61 ... yes 9/62 ... yes 49/63 ... yes 54/64 ... yes 38/66 ... yes 50/67 ... yes 52/68 ... yes 53/69 ... yes 56/70 ... yes 9/71 ... yes 51/72 ... yes 9/73 ... yes 9/74 ... yes 54/75 ... yes 64/76 ... yes 49/78 ... yes 49/79 ... yes 38/80 ... yes 68/81 ... yes 67/82 ... yes 67/83 ... yes 67/84 ... yes 67/85 ... yes 63/86 ... yes 68/88 ... yes 37/89 ... yes 61/90 ... yes 59/91 ... yes 65/92 ... yes 20/93 ... yes 10/97 ... yes 68/98 ... yes 68/100 ... yes 10/101 ... yes 57/103 ... yes 9/105 ... yes 68/106 ... yes 75/107 ... yes 68/110 ... yes 36/111 ... yes 51/112 ... yes 75/114 ... yes 34/115 ... yes 10/116 ... yes 10/117 ... yes 10/118 ... yes 10/119 ... yes 10/120 ... yes 10/121 ... yes 3/122 ... yes 10/123 ... yes 76/124 ... yes 9/125 ... yes 8/127 ... yes 75/128 ... yes 75/129 ... yes 80/130 ... yes 82/131 ... yes 8/132 ... yes 8/133 ... yes 68/134 ... yes 53/135 ... yes 8/137 ... yes 37/138 ... yes 57/139 ... yes 75/140 ... yes 75/141 ... yes 6/142 ... yes 76/143 ... yes 36/144 ... yes 9/145 ... yes 75/146 ... yes 76/148 ... yes 76/149 ... yes 76/150 ... yes 41/151 ... yes 94/152 ... yes 41/153 ... yes 9/154 ... yes 62/155 ... yes 97/156 ... yes 98/157 ... yes 76/158 ... yes 76/159 ... yes 76/160 ... yes 105/161 ... yes 9/162 ... yes 10/163 ... yes 10/164 ... yes 8/165 ... yes 103/166 ... yes 107/167 ... yes 9/168 ... yes 87/169 ... yes 62/170 ... yes 62/171 ... yes 112/172 ... yes 98/173 ... yes 94/174 ... yes 218/175 ... yes 41/176 ... yes 8/177 ... yes 8/178 ... yes 8/179 ... yes 8/180 ... yes 41/181 ... yes 97/183 ... yes 94/184 ... yes 41/185 ... yes 41/186 ... yes 62/187 ... yes 97/188 ... yes 97/189 ... yes 97/190 ... yes 14/192 ... yes 97/193 ... yes 75/194 ... yes 97/195 ... yes 8/197 ... yes 109/199 ... yes 109/200 ... yes 109/201 ... yes 111/202 ... yes 114/203 ... yes 13/204 ... yes 13/205 ... yes 13/206 ... yes 13/207 ... yes 13/208 ... yes 13/209 ... yes 13/210 ... yes 13/211 ... yes 13/212 ... yes 82/213 ... yes 123/214 ... yes 82/215 ... yes 108/216 ... yes 108/217 ... yes 76/218 ... yes 8/219 ... yes 97/220 ... yes 13/221 ... yes 57/222 ... yes 57/224 ... yes 57/225 ... yes 57/226 ... yes 57/227 ... yes 76/228 ... yes 68/229 ... yes 68/230 ... yes 5/232 ... yes 16/233 ... yes 9/234 ... yes 8/235 ... yes 8/236 ... yes 8/238 ... yes 8/240 ... yes 8/241 ... yes 8/242 ... yes 8/243 ... yes 8/244 ... yes 10/245 ... yes 10/246 ... yes 10/247 ... yes 10/248 ... yes 76/249 ... yes 8/250 ... yes 8/251 ... yes 76/252 ... yes 8/253 ... yes 10/254 ... yes 10/255 ... yes 8/256 ... yes 8/257 ... yes 8/258 ... yes 8/259 ... yes 8/260 ... yes 8/261 ... yes 8/262 ... yes 8/263 ... yes 10/264 ... yes 9/265 ... yes 9/266 ... yes 9/267 ... yes 10/268 ... yes 10/269 ... yes 10/270 ... yes 10/271 ... yes 10/272 ... yes 10/273 ... yes 10/274 ... yes 10/275 ... yes 127/276 ... yes 127/277 ... yes 10/278 ... yes 10/279 ... yes 10/280 ... yes 10/281 ... yes 10/282 ... yes 86/283 ... yes 109/284 ... yes 14/285 ... yes 34/287 ... yes 82/289 ... yes 82/290 ... yes 21/291 ... yes 8/293 ... yes 137/294 ... yes 137/295 ... yes 137/296 ... yes 94/297 ... yes 137/299 ... yes 38/300 ... yes 139/301 ... yes 139/302 ... yes 139/303 ... yes 139/304 ... yes 3/305 ... yes 3/306 ... yes 41/307 ... yes 139/308 ... yes 151/309 ... yes 139/310 ... yes 139/311 ... yes 139/312 ... yes 151/313 ... yes 10/314 ... yes 97/315 ... yes 68/316 ... yes 153/317 ... yes 94/318 ... yes 97/320 ... yes 153/321 ... yes 107/322 ... yes 138/323 ... yes 94/324 ... yes 13/325 ... yes 97/326 ... yes 76/327 ... yes 86/328 ... yes 153/329 ... yes 97/330 ... yes 97/331 ... yes 97/332 ... yes 6/333 ... yes 8/335 ... yes 76/336 ... yes 97/337 ... yes 94/338 ... yes 21/339 ... yes 106/340 ... yes 106/341 ... yes 165/342 ... yes 168/343 ... yes 165/344 ... yes 97/345 ... yes 10/346 ... yes 10/347 ... yes 3/348 ... yes 94/349 ... yes 94/350 ... yes 3/351 ... yes 157/352 ... yes 94/353 ... yes 82/354 ... yes 86/355 ... yes 13/356 ... yes 3/357 ... yes 94/358 ... yes 21/360 ... yes 86/362 ... yes 9/363 ... yes 97/364 ... yes 97/365 ... yes 97/366 ... yes 75/367 ... yes 82/368 ... yes 218/369 ... yes 26/370 ... yes 159/371 ... yes 10/372 ... yes 97/373 ... yes 94/374 ... yes 188/375 ... yes 20/376 ... yes 218/377 ... yes 76/378 ... yes 21/379 ... yes 10/380 ... yes 10/381 ... yes 10/382 ... yes 10/383 ... yes 10/384 ... yes 10/385 ... yes 3/386 ... yes 97/387 ... yes 20/388 ... yes 76/389 ... yes 6/390 ... yes 9/391 ... yes 10/392 ... yes 10/393 ... yes 218/394 ... yes 218/395 ... yes 97/397 ... yes 6/398 ... yes 113/399 ... yes 76/400 ... yes 13/401 ... yes 218/402 ... yes 192/404 ... yes 192/405 ... yes 192/406 ... yes 193/407 ... yes 193/408 ... yes 193/409 ... yes 193/410 ... yes 193/411 ... yes 193/412 ... yes 193/413 ... yes 193/414 ... yes 193/415 ... yes 193/416 ... yes 193/417 ... yes 192/418 ... yes 192/419 ... yes 192/420 ... yes 195/421 ... yes 97/422 ... yes 204/423 ... yes 204/424 ... yes 204/425 ... yes 204/426 ... yes 13/427 ... yes 203/428 ... yes 204/429 ... yes 195/430 ... yes 10/432 ... yes 6/433 ... yes 97/434 ... yes 21/435 ... yes 75/436 ... yes 9/437 ... yes 13/438 ... yes 6/439 ... yes 176/440 ... yes 8/441 ... yes 9/442 ... yes 201/443 ... yes 13/444 ... yes 97/445 ... yes 75/446 ... yes 79/447 ... yes 97/448 ... yes 13/449 ... yes 216/450 ... yes 76/451 ... yes 97/454 ... yes 97/455 ... yes 97/459 ... yes 8/460 ... yes 57/461 ... yes 8/463 ... yes 201/464 ... yes 158/465 ... yes 197/466 ... yes 158/467 ... yes 21/468 ... yes 48/469 ... yes 218/470 ... yes 218/471 ... yes 10/472 ... yes 6/473 ... yes 9/474 ... yes 97/476 ... yes 13/477 ... yes 51/478 ... yes 224/479 ... yes 75/480 ... yes 200/483 ... yes 197/484 ... yes 197/485 ... yes 197/486 ... yes 200/487 ... yes 216/488 ... yes 224/489 ... yes 224/490 ... yes 216/491 ... yes 216/492 ... yes 216/493 ... yes 216/494 ... yes 216/495 ... yes 216/496 ... yes 10/497 ... yes 10/498 ... yes 68/499 ... yes 10/500 ... yes 6/501 ... yes 97/502 ... yes 48/503 ... yes 76/504 ... yes 226/505 ... yes 234/506 ... yes 10/507 ... yes 216/508 ... yes 20/509 ... yes 224/510 ... yes 241/511 ... yes 75/512 ... yes 241/513 ... yes 226/514 ... yes 234/515 ... yes 224/517 ... yes 6/518 ... yes 229/519 ... yes 218/520 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.22.0) Git user has default SSH configuration? ... yes Active users: ... 142 Is authorized keys file accessible? ... yes Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
UPDATE: because this should be a rare issue, we decided to prepare steps which can be used for manually restoring missing designs when needed:
- steps to check if there are missing designs: #37252 (comment 566903021)
- steps to manually fix design repository #37252 (comment 567682985)