Pipelines - conjunction/disjunction rule that returns true in one direction and false in the other direction
Summary
In testing job creation rules combining && and || (supported syntax number seven - conjunction/disjunction) I found cases where if the clause is exactly reversed, it incorrectly nets out false instead of true, specifically when the two tests either side of && are performing a == comparison.
This is the basic construct: two jobs, creation conditional on a rule. The same test, forwards and backwards.
if: '$FALS1 && $TRUE2 || $TRUE3'if: '$TRUE3 || $TRUE2 && $FALS1'
Variables TRUE1, TRUE2, TRUE3 can be assumed to be set, ie, they test as true.
Precedence determines how to interpret this, and so it should not matter which way round it is stated.
Both of these net out to true, both jobs get created.
I worked forward from there, adding one == comparison instead of a straight variable test, which worked fine, and then a second, getting to this:
if: '$TRUE1 == "false" && $TRUE2 == "two" || $TRUE3'if: '$TRUE3 || $TRUE2 == "two" && $TRUE1 == "false"'
Same fundamental logic, same effective values. Both should be created. The first does not get created, the second does.
The other "truth table row" which doesn't process properly is as follows. First does not get created, the second does.
if: '$TRUE1 == "false" && $TRUE2 == "false" || $TRUE3'if: '$TRUE3 || $TRUE2 == "false" && $TRUE1 == "false"'
Steps to reproduce
The example yaml below has a set of 'truth tables' showing the basic logic, and increasing the complexity level, and at the point that the two variables either side of the && statement are being tested with ==, the behaviour is exhibited.
Example Project
Identified on Omnibus 12.4.2.
Test yaml which generated the screenshot below is
What is the current bug behavior?
In certain specific circumstances, rules evaluate as false instead of true.
What is the expected correct behavior?
They should evaluate true.
Relevant logs and/or screenshots
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info)[root@bprescott-gitlabtest-0 ~]# sudo gitlab-rake gitlab:env:info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 3.2.12 Git Version: 2.22.0 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.4.2-ee Revision: a3170599aa2 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.9 URL: https://bprescott-gitlabtest-0.do.gitlap.com HTTP Clone URL: https://bprescott-gitlabtest-0.do.gitlap.com/some-group/some-project.git SSH Clone URL: git@bprescott-gitlabtest-0.do.gitlap.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 10.2.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
[root@bprescott-gitlabtest-0 ~]# sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... OK (10.2.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 2/1 ... yes 2/2 ... yes 2/3 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.22.0 ? ... yes (2.22.0) Git user has default SSH configuration? ... yes Active users: ... 1 Is authorized keys file accessible? ... yes Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)