Clearly indicate what approval is for (FE / UX / BE / DB)
Problem
As GitLab staffing numbers grow, it's harder to know on sight who is performing what function when approving
Background
https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines states what approvals an MR needs to have before it's satisfied. Up to now GitLab maintainers have used the "Approve" button, and the final maintainer "just knows" who have approved and what their functions (FE / UX / BE / DB), before merging.
Suggested improvement
It will be nice for the approvers list to automatically setup what role the approval is for. This can happen in one of two ways.
- The MR automatically sets up approval groups
- Each maintainer belongs to a group. When someone clicks approve, the MR shows that e.g. they have approved as "FE Maintainer".
Perhaps we can utilise https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#multiple-approval-rules-premium
Outcome
We can see which function (FE / UX / BE / DB) have approved the MR.