Regression: button links render icon with a dark foreground instead of light
Summary
A number of button links are rendering the icons inside with a dark foreground color instead of white:
Project members page:
Branches page:
What is the current bug behavior?
The foreground is rendered with a dark color.
What is the expected correct behavior?
The foreground is rendered with white.
Output of checks
This bug happens on GitLab.com.
Possible fixes
This was caused by this change: !16479 (diffs).
The added :not(.default-link-color)
made this selector more specific, causing it to be applied in places where it was previously overwritten.
The easiest fix is probably to go back to the original implementation proposed in this thread: !16479 (comment 225630226).