Add policy tab to license list
Problem to solve
This is MVC following ~"product discovery" #12941 (closed)
Be able to view policies from the license list in a new tab so i don't have to go to the settings area
Intended users
- Compliance Role wants to see that they are following policies that have been set, edit policies as needed, and set policies for unclassified licenses.
Further details
Proposal
- add policy tab and display columns license and policy
- display comments icon next to policies in the column if present, don't if not
- mousing over comment icon gets you tooltip with comments
https://gitlab.com/gitlab-org/gitlab/uploads/476eb3f2b7d329f16cd0869dcebdf98d/maintainer.png
Permissions and Security
- not logged in - no tab
- User has at least developer access - no tab
- maintainer - can see tab and edit tab
Documentation
Update docs https://docs.gitlab.com/ee/user/application_security/license_compliance/#project-policies-for-license-compliance with additional way to see policies
Testing
- unit test on NOT seeing as non developer (not logged in, logged in but not dev)
- unit test can't see
- unit test can see as maintainer, and can edit
What does success look like, and how can we measure that?
We are striving to make the person in charge of compliances job direct and with the least amount of manual work or busy work (copy paste). This should make it simpler to interact with all licenses in the project to be able to see their state, and quickly update as needed.
What is the type of buyer?
Links / references
Subissue - implement feature flag in UI to toggle tabs and additional "Policies" tab.
-
Implement feature flag to toggle on and off the displaying of the additional two new tabs "Detected in project" and "Policies" -
Implement tabs. This covers rendering the existing licenses table in "Detected In Project" -
Show counts in the tabs Notes: This will set us up to start merging this work in pieces without exposing it in production
Subissue - Display Add license header in "Policies tab" and table with dropdown and modal
-
Refactor existing add license UI that we use in license management page so we can use it in two places. In particular the add licenses modal and table.(Now covered in Issue 2 since its a good chunk of work) -
Need to decide if we will use client side search or not In the license management page search is done client side. License management uses client side pagination with the Paginated-List component from gitlab-ui. We don't have a re-usable server side pagination table as far as I know. I'm working on one for License List we should be able to use. -
After refactor, implement table and modal. Note: We may have to create an entirely separate issue to refactor the license management views/store.(Issue 2 created below)
Edited by Nicole Schwartz