Revisit column widths in protected branches table
The following discussion from !18352 (merged) should be addressed:
-
@pslaughter started a discussion: (+1 comment) issue (non-blocking): The "matching branches" text has an unfortunately word wrap. Are we sure we want to be setting the
colgroup
in_branches_list.html.haml
Proposal:
diff --git a/app/views/projects/protected_branches/shared/_branches_list.html.haml b/app/views/projects/protected_branches/shared/_branches_list.html.haml index 9dff251101b..e0e3681d5c7 100644 --- a/app/views/projects/protected_branches/shared/_branches_list.html.haml +++ b/app/views/projects/protected_branches/shared/_branches_list.html.haml @@ -6,13 +6,6 @@ = s_("ProtectedBranch|There are currently no protected branches, protect a branch with the form above.") - else %table.table.table-bordered - %colgroup - %col{ width: "20%" } - %col{ width: "20%" } - %col{ width: "20%" } - %col{ width: "20%" } - - if can_admin_project - %col %thead %tr %th
Before After I'll create a follow up issue for this.