UI to expand diffs in MRs is unclear
We really like the addition of "Show all lines" in the diff view of MRs. However, many of our users have found the UI for this confusing, as it's not clear that there are 3 separate buttons to expand different amounts. This led to number of users being frustrated because they thought they had to expand the entire diff of a change, even when it consisted of hundreds of lines.
This was a common enough point of confusion that someone ended up making a video to publicize how to use this feature:
I don't have a great solution here, but I think the main cause of this is that the icons next to the "Show all lines" text look like visual flair rather than separate elements. My suggestion is one of three things:
- Make all the elements text
- Make all the elements icons
- Outline or separate the elements in some way
All of these center around somehow creating a visual distinction between each button, so that it's obvious they're separate and do different things!