Investigate `review-deploy` that takes more than 15 minutes to finish
As we can see in https://gitlab.com/gitlab-org/gitlab/-/jobs/314545008, review-deploy took 33 minutes to finish, even though the Review App was deployed successfully (i.e. in less than 15 minutes). By looking at the timestamps for the job's steps:
- The
prepare-executorsection started atTime.at(1570529032) => 2019-10-08 12:03:52 +0200 - The
prepare-scriptsection started atTime.at(1570529041) => 2019-10-08 12:04:01 +0200 - The
get-sourcessection started atTime.at(1570529044) => 2019-10-08 12:04:04 +0200 - The
restore-cachesection started atTime.at(1570529060) => 2019-10-08 12:04:20 +0200 - The
download-artifactssection started atTime.at(1570529062) => 2019-10-08 12:04:22 +0200 - The
build-scriptsection started atTime.at(1570529065) => 2019-10-08 12:04:25 +0200 - The
after-scriptsection started atTime.at(1570531043) => 2019-10-08 12:37:23 +0200 - The
archive-cachesection started atTime.at(1570531045) => 2019-10-08 12:37:25 +0200 - The
upload-artifacts-on-successsection started atTime.at(1570531047) => 2019-10-08 12:37:27 +0200
So we can see that the build-script section indeed took 33 minutes to complete but we don't have the detailed duration for each step. What we know is that the deploy step cannot take more than 15 minutes. That leaves 18 minutes for the install_api_client_dependencies_with_apk , check_kube_domain , ensure_namespace , install_tiller , install_external_dns , download_chart , and add_license.
We could add date calls between each steps...