GlModal refactor introduces breaking changes
To better follow our design system our
modal component has been changed a good bit in this gitlab-ui MR. This includes removing the
modal-cancel slots, as well as not allowing any content to be placed in the
modal-footer slot. The
modal-footer slot can only be populated via props now.
This will introduce breaking changes anywhere the
modal-cancel slots have been used throughout the codebase.
The gitlab-ui MR will need to be added as a dep for testing while fixing any issues. This way we can visualize how the refactored
modal component will behave. Then we can remove it after any fixes have been applied.
Any instances of our
modal will closely follow the design system.
An example of something that would break can be seen here. This will break because content is passed into the
modal-footer slot. It will only be able to be populated via props now. And any previous actions triggered on content passed into the slot, will need to be moved over to the events that are emitted by the props that populate the
modal-footer slot. We will need to change over any instances in the codebase like this.
GlModal specifically the