Follow-up from "Fix registry tag deletes"
The following discussion from !16886 (merged) should be addressed:
-
@redbaron1 started a discussion: (+1 comment) @ayufan, manifest you've pushed is not unique per request, it can happen that 2 concurrent requests to delete tags from same repo overlap, so that dummy image is delete for both as a result of a single
.delete_repository_tag
call in just one of them, and second would receive "tag not found" error -
Thanks @redbaron1. This is valid suggestion. It seems that we should not produce error in such case, as it is not really an error.
We don't want to push unique per request, as this is not needed.
@ggelatti Could you validate that? It seems that if we get
404
we could safely ignore this and assume this thesuccess
as well.