Banner alerting of project move is showing up everywhere
After all the changes made to CE/EE/FOSS/GitLab projects, there is a blue banner following me everywhere I go.
Example:
I've dismissed this banner countless times, yet it still comes back and haunts me
Steps to reproduce problem
- Alice has issue 1 open
- Alice does not have issue 1 tab in foreground (to stop polling for changes. I believe this is necessary because ETag cache key is based on issue path and so won't be invalidated by changes made after the rename)
- Bob adds a comment or changes title or description of issue 1 (changes must be made before the rename due to cache reason above, and Alice must not have seen those changes before the rename)
- Bob changes project path
- Alice switches to issue 1 tab
- Alice's browser gets 302s on realtime_change or notes XHR requests for that issue (on all subsequent requests!) when the tab is in foreground
Possible fix
Guard https://gitlab.com/gitlab-org/gitlab/blob/v12.2.5-ee/app/controllers/concerns/routable_actions.rb#L51 with request.format.html?.
Edited by Michael Kozono
