~ 1. Are we sure that when we select multiple projects, we get summed up all the data for those? ~
We cannot select Gitlab from the projects, can we extend the list to 50 projects for this release? We are discussing a long term solution for searching for a generic term that doesn't appear in the first 20 with @wortschi for a future milestone.
I don't see the right error message when a group is not premium (productivity vs ):
From the FE perspective, the project IDs are sent through to the API and the data which is returned simply gets displayed without additional computation. I can confirm that from the FE perspective, the project IDs are being sent through when multiple projects are selected.
@blabuschagne - actually, I added one thing we identified with productivity analytics:
We cannot select Gitlab from the projects, can we extend the list to 50 projects for this release? We are discussing a long term solution for searching for a generic term that doesn't appear in the first 20 with @wortschi for a future milestone.
We cannot select Gitlab from the projects, can we extend the list to 50 projects for this release? We are discussing a long term solution for searching for a generic term that doesn't appear in the first 20 with @wortschi for a future milestone.
I've already created an MR for this which covers this for Productivity Analytics!16814 (merged)
Thanks @valexieva! The error handling is ready to be merged (pending a passing pipeline) !16099 (merged) - was just waiting on the refactor which was merged yesterday. I'll also be opening an MR to remove the cookie flag which will then direct all traffic to the new, refactored code.
@valexieva the change is on staging but is still behind the cookie flag. I've opened the MR to remove the cookie flag !17341 (merged) and will confirm once that's merged! In the interim, if you wish to view the change on staging, you can enable the cookie by entering document.cookie = "cycle_analytics_app=true" into your browser's console
I cannot see much difference for the refactor, which I guess is what we expect?
Correct
On the error side of things, I actually see both the error message and the fetching error, is that expected or maybe we are not covering some case
That was expected as the original error handling wasn't removed after adding the no access view. Do you like it as is, or should the red error be removed when displaying the no access view?
One unrelated question, why do we have the tiles with - - - rather than a full line as a border?
Regarding the dashed border above - @ekigbo could you perhaps shine some light on this as I think that you introduced the change as part of customisable stages?
The discussion on the error is the only one left, after we can close. @blabuschagne will be sharing same solution as @wortschi for productivity analytics groups ordering and I believe there is already an MR.
All merge requests related to this issue have been resolved - will keep an eye out for when they have been deployed to staging so that @valexieva can perform a final test before we close this
I've taken a look and found that this seems to happen when a sub group has been selected. The error message does not auto clear, but if you click to close it it doesn't appear on a valid group. I'll create an MR to auto clear the error message when making a new selection
@ahegyi could you please confirm if cycle analytics works on a sub group?