Follow-up from "Avoid checking dns rebind protection in validation"
The following discussion from gitlab-ce!32577 should be addressed:
-
@tkuah started a discussion: We should restrict the check to only
badge.errors[:link_url]
so that any un-related validation errors are not affecting this test. I do appreciate that this style is present in this whole spec file. Would it make sense to fix this spec file now ?
Both spec/validators/addressable_url_validator_spec.rb
and spec/lib/gitlab/url_blocker_spec.rb
specs should be refactored because they're quite messy and don't seem homogenized.