/done quick action is available even no To Do exists
Summary
The /todo
quick action can only be used once per issue/mr and user because after setting the state from pending to done the quick action still doesn't show up even after refresh etc. .
The /done
quick action is available in issues/mr even there are no active To Do's for the current user, if the user had a To Do for this issuable before and set this to done.
Steps to reproduce
- Go into any issue preferrably without any To Do for your account
- add a To Do
- close this To Do
- refresh browser
- type
/done
or/todo
in comment area
Example Project
cf. https://gitlab.com/gitlab-org/gitlab-ce/issues/66330
What is the current bug behavior?
I can access /done
even if not meaningful. But I can't access /todo
if it would be reasonable.
What is the expected correct behavior?
Enable /done
as described in the docs to mark a To Do as done. So if no To Do for this user and this issue exists, the quick action shouldn't be available. The same for /todo
, which should be available if no active To Do for the user exists.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
(and GDK)
Possible fixes
Condition in issuable_actions.rb#L166 seems existent but probably in a helper this issue arises.