Discuss the auto addition of 'Closes #xxx' when a new MR is created from an Issue
Challenge
Reference: gitlab-com/www-gitlab-com!27470 (comment 202424423)
When creating a new MR from an Issue (e.g. #99999
), the new MR will automatically have the expression Closes #99999
added to the bottom of the description.
With the creation of the auto deploy transition overview, the preferred method for closing Issues is to:
- Tag the Issue with gitlab-ce~11090870
- Merge the associated MR(s)
- Keep the Issue open until the developer has verified the fix and presumably removes the gitlab-ce~11090870 label
The preferred method for closing Issues above is currently not compatible if the MR is associated with an Issue because of the automatic addition of the Closes #99999
expression into the description because once the MR is merged, the Issue will automatically be closed.
Proposal
Some options available to us:
- Remember to remove the
Closes #99999
from the MR description - Add a checkbox when creating a new MR from an Issue to control whether or not the
Closes #99999
expression is added. The default state of the checkbox could be driven by either a project or group level setting to make it easier to administer:
cc @pedroms, @alexbuijs, @reprazent, @nick.thomas, @fabiopitino