Checkboxes in Issues are not saving any changes, including checks and unchecks.
Task 1
Task 2
Task 3
Task 4
Task 5
Task 6
Task 7
[ ]
Test this task.
Task 8
I've split the summary issue below into a new issue, #36664 (closed)
No blank line after summary element breaks my onboarding list
1. [ ] People Ops: Double check that the `Employment Status` in BambooHR has two entries marked as `Probation Period` with date as the hire date and `probation period ends` with the end date as exactly 6 months from the hire date.
Task 9
Task 10
Task 11
Gitlab Edition 12.0.3
Having difficulty reproducing it here.
Anyone having similar issues on a released edition of Gitlab?
Other Notes
You can see in the Activity Pane that sometimes the change saves and everything will change back upon refreshing the page or re-saving the issue.
This seems to occur for checkboxes that are after an empty checkbox, as shown in the example above.
This is the request payload for that ajax request.
{"issue":{"description":"## Commerce Updates\n\n### Issues\n* [ ] Shipping is being added for Subscription Orders.\n* [ ] Payment Information Pane could use similar logic as Shipping Information pane to pre-populate billing address.\n\n### Custom Modules that depend on Commerce (and may need updates)\n~~usni_commerce (and submodules)~~\n * ~~CombinedCheckoutFlow~~\n * ~~Custom Checkout Panes~~\n * ~~UsniLogin.php~~\n * ~~SubscriptionShippingInformation.php~~\n * ~~Test/Implement OrderShipmentSummaryInterface~~\n * ~~UsniPaymentInformation.php~~\n * ~~GiftRecipientInformation.php~~\n * ~~OrderComments.php~~\n * ~~SubscriptionOrderSummary.php~~\n * ~~SubscriptionRenewal.php~~\n * ~~UsniCompletionMessage.php~~\n * ~~Handling Adjustments~~\n * ~~Tax Adjustments~~\n * ~~Member/International Prices~~\n * ~~Order Queueing and updateOrderWithPaymentMethodId()~~\n * ~~CartEvents::CART_ENTITY_ADD~~\n * ~~CartEvents::CART_ORDER_ITEM_REMOVE~~\n * ~~TaxEvents::CUSTOMER_PROFILE~~\n * ~~.module file~~\n * ~~Submodule usni_commerce_mail~~\n * ~~Submodule usni_commerce_authnet_profile_management~~\n* [x] usni_data_sync\n* [x] primary_address_sync\n* [x] domestic_based_international_shipping\n* [x] offline_mode\n* [x] product_variation_add_to_cart\n* [x] usni_donation\n\n### Custom Modules that could use Tests for future Commerce Updates (+ details)\n* [ ] \n\n### Other Tasks\n* [x] Test to see if https://www.drupal.org/project/commerce_shipping/issues/2877534 is not an issue.\n* [x] Test Module usni_cart_button\n* [x] Test Module usni_commerce_gift_promotion\n* [x] Test Module usni_member_price_formatter\n* [x] Remove traces of $profile_object->getOwner()\n* [ ] Test applyLandingPageCodes() once Paragraphs is updated.\n\n### Drupal Issues still being worked on (Not implemented on site)\n* [ ] ~~Add support for the Commerce 2.14 address book | **This depends on commits in the commerce dev branch. Hold this and work on other parts until another commerce update is released** > https://www.drupal.org/project/commerce_shipping/issues/3054351~~\n* [x] Provide a way to collect all order profiles (billing, shipping, etc) > https://www.drupal.org/project/commerce/issues/3060433 \n* [ ] https://www.drupal.org/project/commerce_shipping/issues/2849756\n\n## Potential Problems.\n#### commerce_order Database Update 8206 > Clears all Profiles\nThis is done to avoid duplicates. We need to prevent this sync from getting pushed to Salesforce or preserve the Primary Address.\n\n# Notes for Deployment.\n* Import default profile address configuration before running the Database update!! This will prevent addresses with just the U.S. country set to it. Working on Upgrade Path > https://www.drupal.org/project/commerce/issues/3066454","lock_version":97,"update_task":{"index":14,"checked":true,"line_number":45,"line_source":"* [x] Remove traces of $profile_object->getOwner()"}}}
And the Response
{"id":7945,"iid":489,"description":"## Commerce Updates\n\n### Issues\n* [ ] Shipping is being added for Subscription Orders.\n* [ ] Payment Information Pane could use similar logic as Shipping Information pane to pre-populate billing address.\n\n### Custom Modules that depend on Commerce (and may need updates)\n~~usni_commerce (and submodules)~~\n * ~~CombinedCheckoutFlow~~\n * ~~Custom Checkout Panes~~\n * ~~UsniLogin.php~~\n * ~~SubscriptionShippingInformation.php~~\n * ~~Test/Implement OrderShipmentSummaryInterface~~\n * ~~UsniPaymentInformation.php~~\n * ~~GiftRecipientInformation.php~~\n * ~~OrderComments.php~~\n * ~~SubscriptionOrderSummary.php~~\n * ~~SubscriptionRenewal.php~~\n * ~~UsniCompletionMessage.php~~\n * ~~Handling Adjustments~~\n * ~~Tax Adjustments~~\n * ~~Member/International Prices~~\n * ~~Order Queueing and updateOrderWithPaymentMethodId()~~\n * ~~CartEvents::CART_ENTITY_ADD~~\n * ~~CartEvents::CART_ORDER_ITEM_REMOVE~~\n * ~~TaxEvents::CUSTOMER_PROFILE~~\n * ~~.module file~~\n * ~~Submodule usni_commerce_mail~~\n * ~~Submodule usni_commerce_authnet_profile_management~~\n* [x] usni_data_sync\n* [x] primary_address_sync\n* [x] domestic_based_international_shipping\n* [x] offline_mode\n* [x] product_variation_add_to_cart\n* [x] usni_donation\n\n### Custom Modules that could use Tests for future Commerce Updates (+ details)\n* [ ] \n\n### Other Tasks\n* [x] Test to see if https://www.drupal.org/project/commerce_shipping/issues/2877534 is not an issue.\n* [x] Test Module usni_cart_button\n* [x] Test Module usni_commerce_gift_promotion\n* [x] Test Module usni_member_price_formatter\n* [x] Remove traces of $profile_object->getOwner()\n* [ ] Test applyLandingPageCodes() once Paragraphs is updated.\n\n### Drupal Issues still being worked on (Not implemented on site)\n* [ ] ~~Add support for the Commerce 2.14 address book | **This depends on commits in the commerce dev branch. Hold this and work on other parts until another commerce update is released** > https://www.drupal.org/project/commerce_shipping/issues/3054351~~\n* [x] Provide a way to collect all order profiles (billing, shipping, etc) > https://www.drupal.org/project/commerce/issues/3060433 \n* [ ] https://www.drupal.org/project/commerce_shipping/issues/2849756\n\n## Potential Problems.\n#### commerce_order Database Update 8206 > Clears all Profiles\nThis is done to avoid duplicates. We need to prevent this sync from getting pushed to Salesforce or preserve the Primary Address.\n\n# Notes for Deployment.\n* Import default profile address configuration before running the Database update!! This will prevent addresses with just the U.S. country set to it. Working on Upgrade Path > https://www.drupal.org/project/commerce/issues/3066454","title":"Commerce Updates","time_estimate":0,"total_time_spent":0,"human_time_estimate":null,"human_total_time_spent":null,"state":"opened","milestone_id":null,"updated_by_id":66,"created_at":"2019-07-05T15:52:24.864Z","updated_at":"2019-07-29T15:25:27.743Z","milestone":null,"labels":[{"id":9700,"title":"Backend","color":"#428BCA","description":"Development-specific bug","group_id":null,"project_id":435,"template":false,"text_color":"#FFFFFF","created_at":"2017-03-17T19:09:47.314Z","updated_at":"2017-03-17T19:09:47.314Z"}],"lock_version":97,"author_id":66,"confidential":false,"discussion_locked":null,"assignees":[{"id":66,"name":"Jonathan Eom","username":"jeom","state":"active","avatar_url":"https://gitlab.utdev.com/uploads/-/system/user/avatar/66/avatar.png","web_url":"https://gitlab.utdev.com/jeom"}],"due_date":null,"moved_to_id":null,"project_id":435,"web_url":"/usni/usni-d8/issues/489","current_user":{"can_create_note":true,"can_update":true,"can_award_emoji":true},"create_note_path":"/usni/usni-d8/notes?target_id=7945&target_type=issue","preview_note_path":"/usni/usni-d8/preview_markdown?target_id=489&target_type=Issue"}
Did you want the full initial http request output?
I have added a failing case to the issue description. In this case, there is a missing blank line after the <summary> tag. Such that the markdown is:
<details><summary>No blank line after summary element breaks my onboarding list</summary>1. [ ] People Ops: Double check that the `Employment Status` in BambooHR has two entries marked as `Probation Period` with date as the hire date and `probation period ends` with the end date as exactly 6 months from the hire date.</details>
When I change the markdown in my onboarding task description to this:
<details><summary>No blank line after summary element breaks my onboarding list</summary>1. [ ] People Ops: Double check that the `Employment Status` in BambooHR has two entries marked as `Probation Period` with date as the hire date and `probation period ends` with the end date as exactly 6 months from the hire date.</details>
Yes, I tried Alex's suggestion on my onboarding issue. It all works fine for me now as well. It seems that the second section of ### For employees in Australia only have missing space which seems to cause the checkbox render as just text. I suppose it is supposed to be labeled as People Ops as well, but that's unlikely related to this issue.
I suppose it is copied from a template so you may be able to replicate the issue with that. The funny thing is only certain checkboxes were not working and not necessarily the checkbox after that line. You might need to check quite a few checkboxes and refresh the page and see if any of them were not saved.
Thanks @alexpooley. I figured that was where it was, but I didn't find the word "Asutralia" in the onboarding document. TIL we now support including fragments, and that's where it was located.