Private/Internal (Sub)Group email notifications not sent when mentioned in MR description
Summary
Whenever a group or subgroup is mentioned in the description of a MR, if the group or subgroup visibility is private or internal, no one on those groups will be notified by email.
This only happens for mention in the description. Mentions in comments/discussions work as expected.
Steps to reproduce
- Create a private or internal visibility group or subgroup and assign some people to it with correct notifications that would enable them to receive mail notifications
- Edit the description of a MR and mention the target (sub)group
- Check if the (sub)group members receive the notification
What is the current bug behavior?
Mail notification is not sent
What is the expected correct behavior?
Everyone belonging to the (sub)group and with correct notification level should receive an email when mentioned in the description of a Merge Request, no matter the visibility level.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information
System: Debian 8.11
Current User: git
Using RVM: no
Ruby Version: 2.6.3p62
Gem Version: 2.7.9
Bundler Version:1.17.3
Rake Version: 12.3.2
Redis Version: 3.2.12
Git Version: 2.21.0
Sidekiq Version:5.2.7
Go Version: unknown
GitLab information
Version: 12.0.3
Revision: 08a51a9db93
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 10.7
URL: -
HTTP Clone URL: -
SSH Clone URL: -
Using LDAP: no
Using Omniauth: yes
Omniauth Providers:
GitLab Shell
Version: 9.3.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
The programs included with the Debian GNU/Linux system are free software; the exact distribution terms for each program are described in the individual files in /usr/share/doc/*/copyright.
Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent permitted by applicable law. Last login: Wed Jul 10 16:59:39 2019 from 172.16.31.11 debian@gitlab:~$ sudo gitlab-rake gitlab:env:info
System information System: Debian 8.11 Current User: git Using RVM: no Ruby Version: 2.6.3p62 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.0.3 Revision: 08a51a9db93 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 10.7 URL: - HTTP Clone URL: - SSH Clone URL: - Using LDAP: no Using Omniauth: yes Omniauth Providers:
GitLab Shell Version: 9.3.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git debian@gitlab:~$ sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/3 ... yes 3/4 ... yes 3/5 ... yes 3/6 ... yes 3/7 ... yes 3/8 ... yes 3/9 ... yes 3/10 ... yes 3/11 ... yes 3/12 ... yes 3/13 ... yes 3/14 ... yes 3/15 ... yes 14/17 ... yes 14/18 ... yes 14/19 ... yes 14/20 ... yes 14/21 ... yes 14/22 ... yes 14/23 ... yes 14/24 ... yes 14/25 ... yes 7/28 ... yes 7/31 ... yes 7/32 ... yes 16/33 ... yes 16/34 ... yes 16/35 ... yes 3/37 ... yes 15/38 ... yes 15/39 ... yes 15/40 ... yes 15/41 ... yes 15/42 ... yes 15/43 ... yes 15/44 ... yes 15/45 ... yes 15/46 ... yes 17/47 ... yes 17/48 ... yes 3/49 ... yes 3/50 ... yes 3/51 ... yes 3/52 ... yes 3/53 ... yes 3/54 ... yes 3/55 ... yes 3/56 ... yes 3/57 ... yes 3/58 ... yes 17/59 ... yes 17/60 ... yes 17/61 ... yes 7/62 ... yes 6/63 ... yes 3/64 ... yes 42/69 ... yes 42/70 ... yes 42/71 ... yes 42/72 ... yes 42/73 ... yes 42/74 ... yes 42/75 ... yes 42/76 ... yes 42/77 ... yes 42/78 ... yes 42/79 ... yes 42/80 ... yes 42/81 ... yes 42/82 ... yes 42/83 ... yes 42/84 ... yes 42/85 ... yes 42/86 ... yes 42/87 ... yes 42/88 ... yes 42/89 ... yes 42/90 ... yes 42/91 ... yes 42/92 ... yes 42/93 ... yes 42/94 ... yes 42/95 ... yes 42/96 ... yes 42/97 ... yes 42/98 ... yes 42/99 ... yes 42/100 ... yes 42/101 ... yes 42/102 ... yes 42/103 ... yes 42/104 ... yes 42/105 ... yes 42/106 ... yes 42/107 ... yes 42/108 ... yes 42/109 ... yes 42/110 ... yes 42/111 ... yes 42/112 ... yes 42/113 ... yes 42/114 ... yes 42/115 ... yes 42/116 ... yes 42/117 ... yes 42/118 ... yes 42/119 ... yes 42/120 ... yes 42/121 ... yes 42/122 ... yes 42/123 ... yes 42/124 ... yes 42/125 ... yes 42/126 ... yes 42/127 ... yes 42/128 ... yes 42/129 ... yes 42/130 ... yes 42/131 ... yes 42/132 ... yes 42/133 ... yes 44/165 ... yes 44/166 ... yes 44/167 ... yes 44/168 ... yes 44/169 ... yes 44/170 ... yes 3/171 ... yes 3/175 ... yes 17/178 ... yes 3/179 ... yes 3/181 ... yes 70/182 ... yes 70/184 ... yes 70/185 ... yes 55/186 ... yes 70/187 ... yes 70/188 ... yes 70/190 ... yes 60/241 ... yes 60/242 ... yes 60/243 ... yes 60/244 ... yes 60/245 ... yes 60/246 ... yes 60/247 ... yes 60/248 ... yes 60/249 ... yes 60/250 ... yes 60/251 ... yes 60/252 ... yes 60/253 ... yes 60/254 ... yes 60/255 ... yes 60/256 ... yes 60/257 ... yes 60/258 ... yes 60/259 ... yes 60/260 ... yes 60/261 ... yes 60/262 ... yes 60/263 ... yes 60/264 ... yes 60/265 ... yes 60/266 ... yes 60/267 ... yes 60/268 ... yes 60/269 ... yes 60/270 ... yes 60/271 ... yes 60/272 ... yes 60/273 ... yes 60/274 ... yes 60/275 ... yes 60/276 ... yes 60/277 ... yes 60/278 ... yes 60/279 ... yes 60/280 ... yes 60/281 ... yes 60/282 ... yes 60/283 ... yes 60/284 ... yes 60/285 ... yes 60/286 ... yes 60/287 ... yes 60/288 ... yes 60/289 ... yes 42/295 ... yes 70/296 ... yes 70/298 ... yes 68/299 ... yes 68/300 ... yes 68/301 ... yes 68/302 ... yes 68/303 ... yes 68/304 ... yes 68/305 ... yes 68/306 ... yes 68/307 ... yes 68/308 ... yes 68/309 ... yes 68/310 ... yes 68/311 ... yes 68/312 ... yes 68/313 ... yes 68/314 ... yes 68/315 ... yes 68/316 ... yes 68/317 ... yes 68/318 ... yes 68/319 ... yes 68/320 ... yes 68/321 ... yes 68/322 ... yes 68/323 ... yes 68/324 ... yes 68/325 ... yes 68/326 ... yes 68/327 ... yes 68/328 ... yes 68/329 ... yes 68/330 ... yes 68/331 ... yes 68/332 ... yes 68/333 ... yes 68/334 ... yes 68/335 ... yes 68/336 ... yes 68/337 ... yes 68/338 ... yes 68/339 ... yes 68/340 ... yes 68/341 ... yes 68/342 ... yes 68/343 ... yes 68/344 ... yes 68/345 ... yes 68/346 ... yes 68/347 ... yes 67/348 ... yes 67/349 ... yes 67/350 ... yes 67/351 ... yes 67/352 ... yes 67/353 ... yes 3/354 ... yes 76/356 ... yes 3/359 ... yes 75/360 ... yes 3/362 ... yes 76/363 ... yes 76/364 ... yes 82/365 ... yes 82/368 ... yes 82/369 ... yes 82/370 ... yes 76/371 ... yes 60/372 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.3) Git version >= 2.21.0 ? ... yes (2.21.0) Git user has default SSH configuration? ... yes Active users: ... 46
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished