Repair UI to stop accidental merge button pushes
When you having finished reviewing a Merge Request and go to approve AND the number of approvals is less than the required limit, then the UI looks like this:
which is fine. However, even though the MINIMUM number of approvals has been reached, most organizations will still encourage further review, after all, the earlier a problem is identified.... Unfortunately, now the UI changes to look like this:
which clearly makes it seem like the merge button is the only button. Consequently there are frequent merges that take place unintentionally due to this poor UI design. There are two ways to fix this: 1. leave the Approve button enabled, 2. have a confirmation dialog after the Merge button is pressed.
Edited by James Ramsay (ex-GitLab)