Auto DevOps: Upgrade to apps/v1 Deployment
Issue
We currently use Helm to deploy with --wait
. --wait
however does not respect Deployments extensions/v1beta1
(Helm issue).
So we added a workaround using kubectl rollout status
.
Solution
-
Update templates/deployment.yaml to use apps/v1
-
Remove the kubectl rollout status
workaround
See also discussion from gitlab-ce!28130:
> Sorry for coming later into this. Have we considered simply removing the rollout check ? The check was added to workaround an issue with `--wait` in Helm.
>
> EDIT: Ah, the issue was https://gitlab.com/gitlab-org/gitlab-ci-yml/merge_requests/195. Okay we will need the rollout check until [`deployment.yaml`](https://gitlab.com/gitlab-org/charts/auto-deploy-app/blob/master/templates/deployment.yaml) is upgraded to `apps/v1` from `extensions/v1beta1`
Edited by Thong Kuah