Once the Pages configuration API is in place it will be necessary to update gitlab-pages to load its configuration from the API instead of the filesystem. This should be done in a way that will allow support for both implementations (API and config file) for a period of time. Shipping two versions of the binary with Omnibus has been considered as an approach.
This will bring the time of pages configuration update from ~30 minutes to almost instant in gitlab.com, including:
time for the project to be visible for the first time
adding new domains
adding SSL certificates
Proposal
This work has already started in this MR, finishing up that work will complete this issue.
Jason Yavorskachanged title from Update gitlab-pages to use that API for virtual host configuration to Speed up Pages initialization time by using configuration API
changed title from Update gitlab-pages to use that API for virtual host configuration to Speed up Pages initialization time by using configuration API
@cstasik if you have time, it's not urgent but it would be nice to rewrite this issue description in terms of value. At the moment it starts with technical details and gets to the value, but it would be more clear to users I think if it was inverted.
Yes, I think that makes sense. This issue is a bit too broad and should be broken down. Please be sure to update the checklist in the description on the epic too - add these items and any others you discover along the way so we can keep track of all the work to be done. &1316 (closed)
@darbyfrey@ogolowinski it looks like this Deliverable item is being broken down into issues that aren't scheduled in this release. If we are booking this implementation issue into %12.5 only to break it down and deliver it in some other release, I would kindly ask that we please not do that to avoid confusion/missed expectations where people think we are delivering the actual feature.
If you want an issue to account for the work needed to break this down into smaller parts, please create a new issue and move this one to the milestone in which it will actually be delivered.
@krasio I am confused about what this issue actually accomplishes - can you explain it?
Is the performance of pages setup immediate or will it still take 3o min after delivering this?
@ogolowinski Yes, this issue is confusing and way too generic, that why we've split the work required in smaller and more specific issues, these are pretty much all listed under the "Virtual Host Changes" section of &1316 (closed).
I closed this issue not because work is done but rather because we track it in these other issues.
immediate or will it still take 3o min after delivering this
Once we are done with all the virtual hosts changes (&1316 (closed)) domain configuration changes will be almost immediate. BTW meanwhile this delay of 30 minutes got reduced to less than 7 minutes (probably because of dependency upgrade) - - gitlab-pages#252 (closed).
Also, was the documentation update
These are all backstage changes so even when we're done there will not be any documentation updates.