Resend a TODO for each time an approval is required on a merge request
When 'Reset approvals on push' is enabled, a new TODO is not sent out when approvals are removed by a push. The TODO appears for each approver when a merge request is created and is automatically cleared for each approver upon the first time he/she approves it, but does not receive a TODO again. This may be considered more of a feature request, but I consider a mismatch between expected behavior based on documentation and actual behavior to be a bug.
Steps to reproduce
- Enable 'Reset approvals on push'
- Approve a merge request
- push another commit onto the merge request
What is the current bug behavior?
No new TODO appears after a merge request has been approved once.
What is the expected correct behavior?
A TODO appears for each time an approval is required instead of only the first time.
Results of GitLab environment info
$ sudo gitlab-rake gitlab:env:info WARNING: The GitLab Enterprise Edition license will expire on 2017-07-01. System information System: Ubuntu 16.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.11.1 Sidekiq Version:5.0.0 GitLab information Version: 9.2.2-ee Revision: b004167 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.1 URL: https://gitlab.gainesville.infiniteenergy.com HTTP Clone URL: https://gitlab.gainesville.infiniteenergy.com/some-group/some-project.git SSH Clone URL: firstname.lastname@example.org:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: no GitLab Shell Version: 5.0.4 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git