IP rate limiting will rate limit the health check endpoint
Zendesk: https://gitlab.zendesk.com/agent/tickets/102685
It looks like our new Rate Limiting feature will block the Health Check endpoint which makes the health check fail.
Repro Steps:
- Enable IP Rate Limiting in the Admin interface.
- Use curl to hit the endpoint faster than the limit.
- Receive a
Retry later
message.
It seems like we have a convention for should_be_skipped
:
https://gitlab.com/search?utf8=%E2%9C%93&snippets=&scope=&search=should_be_skipped&project_id=278964
Proposal
The IP whitelist should be respected by the rate limiter.
Edited by Jeremy Watson (ex-GitLab)