Link to create merge request gives 404 if not logged in
Summary
Following the link (from git push
) to create a merge request gives a 404 page if not logged in.
Steps to reproduce
- Visit a page of the gitlab instance being used and ensure you are not logged in.
- Push a branch to gitlab and observe the link. For example:
$ git push origin HEAD
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 575 bytes | 575.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0)
remote:
remote: To create a merge request for <branch>, visit:
remote: https://<server>/<group>/<repo>/merge_requests/new?merge_request%5Bsource_branch%5D=<branch>
remote:
To <server>:<group>/<repo>.git
* [new branch] HEAD -> <branch>
- Visit the link.
What is the current bug behavior?
Gitlab shows a 404 page.
What is the expected correct behavior?
Gitlab should show something that doesn't make the user think that gitlab is broken. (A page that asks the user to login, then redirects to creating the merge request, would be optimal.)
Fixing this should also allow reverting the change to fix gitlab-ce#21908.
Edited by Matthew Woehlke