Quick actions not working
Summary
Controlling an issue with quick actions does not seem to work properly.
My usual workflow includes relabeling of issues, but since a few version upgrades of Gitlab, this has stopped working.
Interestingly, only /unlabel
and /label
seem to be affected, including /spend
, /remove_time_spent
etc. still work just fine.
Steps to reproduce
-
create two project or group labels
-
create an issue, and add one of the labels
-
create a comment, containing one or both of the following lines:
/label ~otherlabel /unlabel ~firstlabel
-
click submit (or press Ctrl+Enter)
-
notice the labels not changing
-
notice the comment field staying as draft
Additionally, the Webinspector records this submit request/response:
-
request (POST to
/:group/:project/notes?target_id=345&target_type=issue
):note[noteable_type]: issue note[noteable_id]: 345 note[note]: /label ~chore
-
response:
{"commands_changes":null,"valid":false,"errors":{}}
Example Project
The Gitlab instance we're running is private, but it is a standard Omnibus installation without modifications, recently updated to version 11.0.1 (gitlab-ce@bf968f8a3fd4f969e06e0588407ac04a14cfd7dd). As mentioned above, this behaviour started a few versions ago (maybe in April?)
What is the current bug behavior?
Labels via /label
and /unlabel
quick actions are not applied to an issue.
What is the expected correct behavior?
Labels are applied.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com (only in this issue, but here I'm lacking permisions. In one of my private repos it works as expected).
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 18.04 Current User: gitlab Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.17.1 Sidekiq Version:5.1.3 Go Version: unknown
GitLab information Version: 11.0.1 Revision: bf968f8a3fd Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://[REDACTED] HTTP Clone URL: https://[REDACTED]/some-group/some-project.git SSH Clone URL: gitlab@[REDACTED]:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 7.1.4 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...
GitLab Shell version >= 7.1.4 ? ... OK (7.1.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by gitlab:root, or gitlab:gitlab? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 3/1 ... ok 7/2 ... ok 3/3 ... ok 3/4 ... ok 3/5 ... ok 3/7 ... ok 3/8 ... ok 3/9 ... ok 7/10 ... repository is empty 3/11 ... ok 3/12 ... ok 3/13 ... ok 14/14 ... ok 14/15 ... ok 3/16 ... ok 3/17 ... ok 14/18 ... ok 6/20 ... ok 3/21 ... ok 6/22 ... ok 16/23 ... ok 17/24 ... ok 6/25 ... ok 14/26 ... ok 14/27 ... ok 3/28 ... ok 20/29 ... ok 3/30 ... ok 22/31 ... ok 23/32 ... ok 20/33 ... ok 3/34 ... ok 6/35 ... ok 3/36 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/1 ... yes 7/2 ... yes 3/3 ... yes 3/4 ... yes 3/5 ... yes 3/7 ... yes 3/8 ... yes 3/9 ... yes 7/10 ... yes 3/11 ... yes 3/12 ... yes 3/13 ... yes 14/14 ... yes 14/15 ... yes 3/16 ... yes 3/17 ... yes 14/18 ... yes 6/20 ... yes 3/21 ... yes 6/22 ... yes 16/23 ... yes 17/24 ... yes 6/25 ... yes 14/26 ... yes 14/27 ... yes 3/28 ... yes 20/29 ... yes 3/30 ... yes 22/31 ... yes 23/32 ... yes 20/33 ... yes 3/34 ... yes 6/35 ... yes 3/36 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.17.1) Git user has default SSH configuration? ... yes Active users: ... 13
Checking GitLab ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)