Consider always using matchers with defined elements in QA scenarios expectations
The problem
We recently had a failure were QA weren't run in gitlab-ee#6534, thus introducing failures in the nightly QA run.
The problem in this case was that we have an expectation for a given text but we don't have any element
that ensure that this text doesn't change without breaking the qa:selectors
job.
The proposal
We should define matchers in Page
objects and these Page
objects should define element
s for any text or CSS class used in the matcher. A good example can be found in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19228/diffs with the has_label?
matcher.