Subgroup permissions are not correctly obeyed when moving subgroup issues on a group level issue board
Summary
Subgroup permissions are not correctly obeyed when moving subgroup issues on a group level issue board.
Steps to reproduce
- Add user User to group Group.
- Set permission of User to 'guest' of Group
- Create subgroup SubGroup.
- Set permission of UserA to 'developer' of SubGroupB
- Create an issue in SubGroup
- Go to the SubGroup subgroup-level issue board. We can move the issue on the board (change label). This is expected as we have the correct permissions.
- Go to the Group group-level issue board. We cannot move the issue on the board. This is unexpected as we have the correct permissions for SubGroup to do this.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behaviour, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug has been fixed in a more recent version)
What is the current bug behavior?
We can move the issue on the subgroup-level board (change label). This is expected as we have the correct permissions. We cannot move the issue on the board. This is unexpected as we have the correct permissions for SubGroup to do this.
What is the expected correct behavior?
We can move the issue on the subgroup-level board (change label). This is expected as we have the correct permissions. We can move the issue on the board as we have the correct permissions for SubGroup to do this.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.6p384 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.3.0 Redis Version: 3.2.11 Git Version: 2.14.3 Sidekiq Version:5.0.5 Go Version: unknown
GitLab information Version: 10.7.0 Revision: 2011c9b Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://git.goldstandardphantoms.com HTTP Clone URL: https://git.goldstandardphantoms.com/some-group/some-project.git SSH Clone URL: git@git.goldstandardphantoms.com:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 7.1.2 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 7.1.2 ? ... OK (7.1.2) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 3/1 ... ok 4/2 ... ok 4/3 ... ok 4/4 ... ok 4/5 ... ok 6/6 ... ok 5/8 ... ok 5/9 ... ok 4/10 ... ok 5/11 ... ok 5/12 ... ok 21/13 ... ok 5/14 ... ok 4/15 ... ok 4/16 ... ok 4/17 ... ok 5/19 ... ok 3/20 ... ok 4/21 ... ok 21/22 ... ok 9/23 ... ok 9/24 ... ok 9/25 ... ok 9/26 ... ok 9/27 ... ok 9/28 ... ok 5/29 ... ok 4/30 ... ok 5/31 ... ok 9/32 ... ok 5/33 ... ok 5/34 ... ok 21/35 ... ok 12/37 ... ok 4/38 ... ok 4/39 ... ok 21/40 ... ok 21/41 ... ok 15/42 ... repository is empty 4/43 ... ok 21/44 ... ok 21/45 ... ok 15/46 ... repository is empty 17/47 ... ok 17/49 ... ok 18/50 ... repository is empty 17/52 ... ok 21/53 ... ok 17/54 ... ok 17/55 ... ok 17/56 ... ok 17/57 ... ok 21/58 ... ok 21/59 ... ok 21/60 ... ok 15/61 ... repository is empty 4/62 ... ok 5/63 ... ok 21/67 ... ok 17/68 ... ok 17/70 ... repository is empty 5/71 ... ok 4/72 ... ok 17/73 ... ok 21/74 ... ok 22/75 ... repository is empty 22/76 ... repository is empty 22/77 ... repository is empty 22/78 ... repository is empty 15/79 ... ok 15/80 ... repository is empty 21/81 ... repository is empty 21/82 ... repository is empty 22/83 ... repository is empty Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 3/1 ... yes 4/2 ... yes 4/3 ... yes 4/4 ... yes 4/5 ... yes 6/6 ... yes 5/8 ... yes 5/9 ... yes 4/10 ... yes 5/11 ... yes 5/12 ... yes 21/13 ... yes 5/14 ... yes 4/15 ... yes 4/16 ... yes 4/17 ... yes 5/19 ... yes 3/20 ... yes 4/21 ... yes 21/22 ... yes 9/23 ... yes 9/24 ... yes 9/25 ... yes 9/26 ... yes 9/27 ... yes 9/28 ... yes 5/29 ... yes 4/30 ... yes 5/31 ... yes 9/32 ... yes 5/33 ... yes 5/34 ... yes 21/35 ... yes 12/37 ... yes 4/38 ... yes 4/39 ... yes 21/40 ... yes 21/41 ... yes 15/42 ... yes 4/43 ... yes 21/44 ... yes 21/45 ... yes 15/46 ... yes 17/47 ... yes 17/49 ... yes 18/50 ... yes 17/52 ... yes 21/53 ... yes 17/54 ... yes 17/55 ... yes 17/56 ... yes 17/57 ... yes 21/58 ... yes 21/59 ... yes 21/60 ... yes 15/61 ... yes 4/62 ... yes 5/63 ... yes 21/67 ... yes 17/68 ... yes 17/70 ... yes 5/71 ... yes 4/72 ... yes 17/73 ... yes 21/74 ... yes 22/75 ... yes 22/76 ... yes 22/77 ... yes 22/78 ... yes 15/79 ... yes 15/80 ... yes 21/81 ... yes 21/82 ... yes 22/83 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.6) Git version >= 2.9.5 ? ... yes (2.14.3) Git user has default SSH configuration? ... no Try fixing it: mkdir ~/gitlab-check-backup-1524664469 sudo mv /var/opt/gitlab/.ssh/config~ ~/gitlab-check-backup-1524664469 sudo mv /var/opt/gitlab/.ssh/bitbucket_rsa.pub ~/gitlab-check-backup-1524664469 sudo mv /var/opt/gitlab/.ssh/bitbucket_rsa ~/gitlab-check-backup-1524664469 sudo mv /var/opt/gitlab/.ssh/config ~/gitlab-check-backup-1524664469 For more information see: doc/ssh/README.md in section "SSH on the GitLab server" Please fix the error above and rerun the checks. Active users: ... 12
Checking GitLab ... Finished
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)