Show failure description on non-failed jobs's view content section
(Potentially to be considered part of: https://gitlab.com/gitlab-org/gitlab-ce/issues/41111 )
This issue stems from a discussion on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17814 re: https://gitlab.com/gitlab-org/gitlab-ce/issues/44271
There we added the failure description on FAILED jobs.
@dimitrieh suggested adding that error callout to all other job statuses that have a failure message. (Fail and Allowed to fail are handled in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17814 )
@mayra-cabrera highlighted that the failure description might occur on other states as well, raising the question of in which ones should we show the failure reason.
Failed Job (done in gitlab-ce!17814)
Some important notes
- Color of the callout: should it be red or yellow:
@dimitrieh This is up to our interpretation. I would like to have it red though as the job is allowed to fail, but the callout has nothing to do with that. It stays a failure message :)
- Other non-failure states returning a failure_description
@mayra-cabrera success jobs are also allowed to fail, so if a job succeed it could possible return a failure_description.