No slack notifications for wiki page edits done using direct git
Summary
When making changes to wiki using direct git push, no notifications are sent to Slack, even though both push and wiki page change notifications are enabled. Push changes work for code changes, and wiki notifications work if the wiki edits are done using the online browser editor, but not if they are done through direct git push to the wiki repo.
Steps to reproduce
- Configure and enable all Slack notifications for a project
- Clone a wiki's repo from the project
- Make some changes, and push
--> No notifications appear in Slack.
What is the current bug behavior?
Nothing.
What is the expected correct behavior?
A wiki page edit notification is sent to Slack.
(Well I wouldn't mind a push notification, that would be an improvement, but I guess it wouldn't be quite "correct".)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 8.10 Current User: git Using RVM: no Ruby Version: 2.3.6p384 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.3.0 Redis Version: 3.2.11 Git Version: 2.14.3 Sidekiq Version:5.0.5 Go Version: unknown
GitLab information Version: 10.5.6 Revision: 4b41d48 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://... HTTP Clone URL: https://.../some-group/some-project.git SSH Clone URL: git@...:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 6.0.3 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 6.0.3 ? ... OK (6.0.3) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 4/2 ... ok 6/3 ... ok 8/4 ... ok 11/5 ... ok 12/6 ... ok 12/7 ... ok 11/9 ... ok 11/10 ... ok 12/11 ... ok 12/12 ... ok 11/13 ... ok 11/14 ... ok 5/15 ... ok 11/16 ... ok 12/17 ... ok 11/18 ... ok 9/19 ... ok 12/20 ... ok 17/22 ... ok 17/23 ... ok 11/24 ... ok 6/25 ... ok 5/26 ... ok 17/27 ... ok 17/28 ... ok 12/29 ... ok 12/31 ... ok 24/33 ... ok 25/34 ... ok 24/39 ... ok 21/41 ... ok 24/42 ... ok 27/43 ... ok 4/44 ... ok 24/45 ... ok 24/46 ... ok 25/47 ... ok 12/49 ... ok 28/50 ... ok 27/52 ... ok 27/55 ... ok 25/57 ... ok 25/58 ... ok 12/59 ... ok 12/61 ... ok 25/62 ... ok 3/63 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 4/2 ... yes 6/3 ... yes 8/4 ... yes 11/5 ... yes 12/6 ... yes 12/7 ... yes 11/9 ... yes 11/10 ... yes 12/11 ... yes 12/12 ... yes 11/13 ... yes 11/14 ... yes 5/15 ... yes 11/16 ... yes 12/17 ... yes 11/18 ... yes 9/19 ... yes 12/20 ... yes 17/22 ... yes 17/23 ... yes 11/24 ... yes 6/25 ... yes 5/26 ... yes 17/27 ... yes 17/28 ... yes 12/29 ... yes 12/31 ... yes 24/33 ... yes 25/34 ... yes 24/39 ... yes 21/41 ... yes 24/42 ... yes 27/43 ... yes 4/44 ... yes 24/45 ... yes 24/46 ... yes 25/47 ... yes 12/49 ... yes 28/50 ... yes 27/52 ... yes 27/55 ... yes 25/57 ... yes 25/58 ... yes 12/59 ... yes 12/61 ... yes 25/62 ... yes 3/63 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.6) Git version >= 2.9.5 ? ... yes (2.14.3) Git user has default SSH configuration? ... yes Active users: ... 19
Checking GitLab ... Finished