URL for GitLab TODO that links to a design image incorrectly omits `version` query param

Summary

As per title. If I get @mentioned in a design image part of an old collection, and click on the GitLab TODO for the mention, I am redirected to the correct path, however the version query param is missing.

Steps to reproduce

  1. Tag yourself in a design image that is part of an old collection (but not the latest collection)
  2. Receive the TODO, and click on it
  3. Observe. You will get an endless loading spinner

Example URL:

This is a URL I got in a TODO: https://gitlab.com/gitlab-org/gitlab/issues/38048/designs/Screen_Shot_2020-02-18_at_4.15.11_PM.png. This image is only available in a previous version of the design collection (not in the latest one), so linking to the "latest version" (i.e. no query param) is "404"

Bad url (no query param): https://gitlab.com/gitlab-org/gitlab/issues/38048/designs/Screen_Shot_2020-02-18_at_4.15.11_PM.png Good url (has version query param): https://gitlab.com/gitlab-org/gitlab/issues/38048/designs/Screen_Shot_2020-02-18_at_4.15.11_PM.png?version=3485

Output of checks

This bug happens on GitLab.com

Edited by Tom Quirk