max-nesting-depth (level 5) in stytlelint
Description
Just enabled max-nesting-depth
in stylelint
(gitlab-foss#39582 (closed), gitlab-foss!15073 (merged)) with max_depth
6, we need to make more efforts to keep CSS simple for continuous development.
Note: until 2021-02, the issue title was about NestingDepth
in scss-lint
but due to !53700 (merged), we changed the title.
Proposal
Final goal of #16217 (closed) (formerly known as gitlab-foss#23485 (moved)) in max-nesting-depth
is level 4 and this issue (level 5) is the second step of it (probably consisted of three phases) as the first step (level 6) was achieved in gitlab-foss#39582 (closed) (gitlab-foss!15073 (merged)).
gitlab (now known as EE) on SCSS-Lint
Sub-tasks atThe number of the violations followed by filename at master ee8e6fa5 (2020-10-28):
- 2 app/assets/stylesheets/framework/contextual_sidebar.scss
- 4 app/assets/stylesheets/framework/diffs.scss
- 5 app/assets/stylesheets/framework/files.scss
-
8 app/assets/stylesheets/framework/gitlab_theme.scss
-
2 app/assets/stylesheets/framework/header.scss
(2020-10) - 4 app/assets/stylesheets/framework/typography.scss
-
1 app/assets/stylesheets/pages/groups.scss
(2020-10) -
3 app/assets/stylesheets/pages/incident_management_list.scss
(2020-10) -
2 app/assets/stylesheets/pages/issuable.scss
(2020-06?) - 4 app/assets/stylesheets/pages/notes.scss
-
5 app/assets/stylesheets/themes/theme_helper.scss
(2020-10) -
5 app/assets/stylesheets/themes/theme_light.scss
(2020-10) - 1 ee/app/assets/stylesheets/components/batch_comments/draft_note.scss
-
2 ee/app/assets/stylesheets/pages/roadmap.scss
%12.4
- 3 ee/app/assets/stylesheets/pages/billings.scss (!15437 (merged)) by @rhardarson
%11.10
gitlab-foss!26493 (merged) (app/assets/stylesheets/pages/diff.scss
)
%11.1 - %11.9
n/a
%11.0
- 10 app/assets/stylesheets/pages/pipelines.scss (gitlab-foss!18830 (merged))
%10.8
- 1 app/assets/stylesheets/pages/login.scss gitlab-foss!16275 (merged)
%10.7
- 1 app/assets/stylesheets/framework/dropdowns.scss gitlab-foss!17820 (merged)
%10.5
- 1 app/assets/stylesheets/pages/cycle_analytics.scss gitlab-foss!16270 (merged)