HTTP 400 when removing/deleting a branch
Summary
When clicking on "Delete branch" for a "merged" branch and confirm the popped up dialog nothing happens. I see a 400 Bad Request in the browser network console. The branch contains a "/", maybe this is the error?
What is the expected correct behavior?
First: The GUI should display an error message that removing the branch did not work.
Second: The HTTP Response should contain an error message about the problem. The logfiles should contain something, too.
Third: The branch should be removable.
Relevant logs and/or screenshots
curl 'https://***/branches/***%2F45255-unbound-local-ur' -X DELETE -H 'Accept: */*;q=0.5, text/javascript, application/javascript, application/ecmascript, application/x-ecmascript' -H 'Accept-Encoding: gzip, deflate, br' -H 'Accept-Language: en-US,en;q=0.7,de-DE;q=0.3' -H 'Connection: keep-alive' -H 'Cookie: user_callout_dismissed=true; new_nav=false; sidebar_collapsed=false; _gitlab_session=****' -H 'Host: ***' -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0' -H 'X-CSRF-Token: kXI2NM+48z/****/e+4i85hNBs/sEccFY1F4X93ZNlD7UDxafJrOId+hmPMnPryXQw==' -H 'X-Requested-With: XMLHttpRequest' -i
HTTP/1.1 400 Bad Request
Server: nginx
Date: Wed, 11 Oct 2017 12:29:48 GMT
Content-Type: text/javascript; charset=utf-8
Content-Length: 0
Connection: keep-alive
Cache-Control: no-cache
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
X-Request-Id: 4f408145-e4b5-4212-ad2a-e1cd8df3ccf4
X-Runtime: 0.241361
X-Ua-Compatible: IE=edge
X-Xss-Protection: 1; mode=block
root@git:/var/log/gitlab# tail -f */*.log:
==> gitlab-rails/api_json.log <==
{"time":"2017-10-11T12:29:48.579Z","severity":"INFO","duration":14.22,"db":2.97,"view":11.25,"status":200,"method":"POST","path":"/api/v4/internal/allowed","params":{"action":"git-receive-pack","changes":"bea5bf7b99244f1ea629080a7e065c0dfc238b6a 0000000000000000000000000000000000000000 refs/heads/*****45255-unbound-local-ur\n","gl_repository":"project-4","project":"/var/opt/gitlab/git-data/repositories/****/***.git","protocol":"web","env":"{\"GIT_ALTERNATE_OBJECT_DIRECTORIES\":null,\"GIT_OBJECT_DIRECTORY\":null}","user_id":"3","secret_token":"[FILTERED]"},"host":"127.0.0.1","ip":"127.0.0.1","ua":"Ruby"}
{"time":"2017-10-11T12:29:48.585Z","severity":"INFO","duration":0.9,"db":0.0,"view":0.9,"status":200,"method":"POST","path":"/api/v4/internal/pre_receive","params":{"gl_repository":"project-4","secret_token":"[FILTERED]"},"host":"127.0.0.1","ip":"127.0.0.1","ua":"Ruby"}
==> gitlab-rails/production_json.log <==
{"method":"DELETE","path":"/***/**/branches/****%2F****-unbound-local-ur","format":"js","controller":"Projects::BranchesController","action":"destroy","status":400,"duration":222.18,"view":0.59,"db":1.9,"time":"2017-10-11T12:29:48.411Z","params":{"namespace_id":"***","project_id":"***","id":"***/45255-unbound-local-ur"},"remote_ip":"192.168.0.94","user_id":3,"username":"***"}
==> gitlab-rails/production.log <==
Started DELETE "/***/***/branches/***%2F45255-unbound-local-ur" for 192.168.0.94 at 2017-10-11 14:29:48 +0200
Processing by Projects::BranchesController#destroy as JS
Parameters: {"namespace_id"=>"***", "project_id"=>"****", "id"=>"****/45255-unbound-local-ur"}
Started POST "/api/v4/internal/allowed" for 127.0.0.1 at 2017-10-11 14:29:48 +0200
Started POST "/api/v4/internal/pre_receive" for 127.0.0.1 at 2017-10-11 14:29:48 +0200
Completed 400 Bad Request in 221ms (Views: 0.6ms | ActiveRecord: 1.9ms)
==> gitlab-shell/gitlab-shell.log <==
I, [2017-10-11T14:29:48.580869 #15319] INFO -- : POST http://127.0.0.1:8080/api/v4/internal/allowed 0.01928
I, [2017-10-11T14:29:48.586021 #15319] INFO -- : POST http://127.0.0.1:8080/api/v4/internal/pre_receive 0.00424
==> nginx/gitlab_access.log <==
192.168.0.94 - - [11/Oct/2017:14:29:48 +0200] "DELETE /***/***/branches/***%2F45255-unbound-local-ur HTTP/1.1" 400 0 "" "Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0"
Results of GitLab environment info
System information
System: Univention 4.2-1 errata194
Current User: git
Using RVM: no
Ruby Version: 2.3.5p376
Gem Version: 2.6.13
Bundler Version:1.13.7
Rake Version: 12.0.0
Redis Version: 3.2.5
Git Version: 2.13.5
Sidekiq Version:5.0.4
Go Version: unknown
GitLab information
Version: 10.0.3
Revision: 8895150
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
Using LDAP: yes
Using Omniauth: no
GitLab Shell
Version: 5.9.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks
Git: /opt/gitlab/embedded/bin/git