Self-monitoring project button always disabled
Summary
(Summarize the bug encountered concisely)
The self-monitoring project toggle button in the admin section is always disabled, even when the self-monitoring project exists.
Steps to reproduce
(How one can reproduce the issue - this is very important)
- Enable feature flag
self_monitoring_project
. - Go to the Admin area -> Settings -> Metrics and profiling -> Expand Self monitoring
- Click the toggle button to trigger creation of the self-monitoring project.
- Once the project is created, the toggle button should change to enabled, but it doesn't.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
What is the expected correct behavior?
(What you should see instead)
When the self-monitoring project exists, the toggle button should be enabled.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
It appears that the state of the toggle button is controlled by a boolean key in application_settings_helper.rb
. But the boolean value gets passed to Vue as an empty string. Instead, we need to pass the boolean value as a string ("true"
instead of true
).