"Merge request tabs have moved" discoverability feature is annoying
Summary
I'm getting to see this notification several times a day:
Steps to reproduce
- Be me
- Visit any merge request on GitLab.com
I often get this way by clicking a link to an MR in my email client, which opens up a new browser session. There are no cookies, and I'm not logged in. Every time I follow a link like this, I get to see this popup, which is extremely annoying.
Example Project
Happens reliably if I visit a random MR, like !21424 (closed)
What is the current bug behavior?
Popup
What is the expected correct behavior?
No popup, per our product guidelines: https://about.gitlab.com/handbook/product/#discoverability-without-being-annoying
Output of checks
This bug happens on GitLab.com
Possible fixes
I don't know how we're storing the state of this, offhand. We definitely shouldn't use cookies, which suggests we should probably never show it for users who aren't logged in.